Allow whitespaces in START STENCIL directive for name argument #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cscs-ci run default |
1 similar comment
|
cscs-ci run default |
…l_name_syntax_validation
|
cscs-ci run default |
|
launch jenkins spack |
|
cscs-ci run default |
|
launch jenkins spack |
added 2 commits
March 22, 2024 16:17
…l_name_syntax_validation
…l_name_syntax_validation
|
cscs-ci run default |
|
launch jenkins spack |
1 similar comment
|
launch jenkins spack |
|
launch jenkins spack |
|
launch jenkins spack |
This reverts commit a7dd889.
|
launch jenkins spack |
|
cscs-ci run default |
|
launch jenkins spack |
…l_name_syntax_validation
|
cscs-ci run default |
|
launch jenkins spack |
…l_name_syntax_validation
|
cscs-ci run default |
|
launch jenkins spack |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run default |
|
launch jenkins spack |
huppd
approved these changes
Apr 10, 2024
iomaganaris
referenced
this pull request
in iomaganaris/icon4py
Jun 18, 2024
* Allow whitespaces in START STENCIL directive for name argument * Fixed names of stencils used in repeated_stencils test * Added test for whitespaces in name argument * Fixed tests for whitespaces not containing DECLARE and IMPORTS directives * Small fix * Revert "Fixed names of stencils used in repeated_stencils test" This reverts commit a7dd889215a8b22ca493cb7fb53fdd2d2b48f4f3. * Changed test name --------- Co-authored-by: Mikael Stellio <[email protected]>
samkellerhals
deleted the
improve_liskov_stencil_name_syntax_validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies some small changes in the regex matching the
nameargument specified in Liskov'sSTART STENCILdirectives. The new syntax allows having whitespaces on thenameline. E.g.:instead of just